docs: update TIP-1017 spec doc and simplify#2873
Open
howydev wants to merge 10 commits intohowy/val-config-v2-events-fee-recipientfrom
Open
docs: update TIP-1017 spec doc and simplify#2873howydev wants to merge 10 commits intohowy/val-config-v2-events-fee-recipientfrom
howydev wants to merge 10 commits intohowy/val-config-v2-events-fee-recipientfrom
Conversation
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
2 times, most recently
from
fe61eb0 to
dba60eb
Compare
📊 Tempo Precompiles Coverage |
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
2 times, most recently
from
49e68a7 to
ba377a0
Compare
howydev
changed the title
howydev
requested review from
0xKitsune,
0xrusowsky,
dankrad,
danrobinson,
fgimenez,
klkvr,
legion2002 and
mattsse
as code owners
howydev
changed the base branch from
howy/val-config-v2-events
to
howy/val-config-v2-events-fee-recipient
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412
Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412 Co-authored-by: Amp <amp@ampcode.com>
Adds the `feeRecipient` field to val config v2 `Validator` entries. Also introduces the `setFeeRecipient` function to change the fee recipient, and `FeeRecipientUpdated` event. Unclear how this should be added to the spec: 1. this is not expected to be activated until T3. This is in preparation for T3 but won't be implemented in T2. 2. during V1 -> V2 migration, the value is expected to be set to `0x0`. --------- Co-authored-by: howy <132113803+howydev@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
from
f61d22a to
0809e66
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019cb530-4354-7302-955e-a2358a1c8f00 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019cb530-4354-7302-955e-a2358a1c8f00 Co-authored-by: Amp <amp@ampcode.com>
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
from
9f1881f to
0bcc659
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019cb540-7de9-75a3-88bb-b100a06a7eed Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.